Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document some methods in ActionDispatch::ContentSecurityPolicy [skip-ci] #44451

Merged
merged 1 commit into from Feb 17, 2022

Conversation

p8
Copy link
Member

@p8 p8 commented Feb 16, 2022

The Content Security Policy is mostly documented in the guides.
This documents some methods on ActionDispatch::ContentSecurityPolicy.

@rails-bot rails-bot bot added the actionpack label Feb 16, 2022
@p8 p8 force-pushed the docs/add-documentation-for-csp branch 2 times, most recently from 4254da2 to a10cb36 Compare February 16, 2022 19:38
Copy link
Member

@jonathanhefner jonathanhefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor nits, otherwise looks good! 👍

Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
@p8 p8 force-pushed the docs/add-documentation-for-csp branch from 7dc332b to 92d877b Compare February 17, 2022 07:37
# Pass +false+ to allow it again:
#
# policy.block_all_mixed_content false
#
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanhefner Do you think this blank line should be deleted?
I'm seeing both for comments ending with single line code blocks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that we have policy either way. Personally, I think it looks nicer to have it (and for multi-line code blocks, too). 👍

@jonathanhefner jonathanhefner merged commit 5fb0ad3 into rails:main Feb 17, 2022
@jonathanhefner
Copy link
Member

jonathanhefner commented Feb 17, 2022

Thank you, @p8! 🚀

Backported to 7-0-stable in 2e56172.

jonathanhefner added a commit that referenced this pull request Feb 17, 2022
Document some methods in ActionDispatch::ContentSecurityPolicy [skip-ci]

(cherry picked from commit 5fb0ad3)
@p8
Copy link
Member Author

p8 commented Feb 17, 2022

Thanks @jonathanhefner 🙌 !

@p8 p8 deleted the docs/add-documentation-for-csp branch February 17, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants