Improve Content Security Policy documentation [ci-skip] #44470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guides/source/security.md
Outdated
Comment on lines
1146
to
1148
| ``` | ||
|
|
||
| ```ruby |
There was a problem hiding this comment.
When code snippets are from different contexts (e.g. config/initializers/content_security_policy.rb and app/controllers/posts_controller.rb), I prefer to keep the code blocks separate to provide visual distinction in the rendered output. Also, it gives each snippet a dedicated "Copy" button.
(I did some work toward that in #40922.)
- Use "HTTP Content-Security-Policy response header" instead of "Content Security Policy", to make it clear the header will be set. - Instead of having a long list of examples in the guide, add a description to each example. Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
jonathanhefner
added a commit
that referenced
this pull request
Feb 18, 2022
Improve Content Security Policy documentation [ci-skip] (cherry picked from commit 258e9ad)
|
Thanks @jonathanhefner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Security Policy", to make it clear the header will be set.
report_uriin the guides.description to each example.
Before
After