Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicitly assert no exception is raised in assert_queries & al #44484

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Implicitly assert no exception is raised in assert_queries & al #44484

merged 1 commit into from
Feb 19, 2022

Conversation

byroot
Copy link
Member

@byroot byroot commented Feb 19, 2022

Fix: #44397
Ref: #37313
Ref: #42459

This avoid mistakes such as:

assert_raise Something do
  assert_queries(1) do
    raise Something
  end
end

@byroot @drcapulet
Implicitly assert no exception is raised in assert_queries & al
e26372b 
Fix: #44397
Ref: #37313
Ref: #42459

This avoid mistakes such as:

```ruby
assert_raise Something do
  assert_queries(1) do
    raise Something
  end
end
```

Co-Authored-By: Alex Coomans <alexc@squareup.com>
byroot
byroot commented Feb 19, 2022
View reviewed changes
activerecord/test/cases/query_cache_test.rb
@@ -489,9 +489,11 @@ def test_query_cache_does_not_allow_sql_key_mutation
payload[:sql].downcase!
end

assert_raises FrozenError do
ActiveRecord::Base.cache do
assert_queries(1) { Task.find(1); Task.find(1) }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not quite clear what this was testing.

@byroot byroot merged commit ce1806d into main Feb 19, 2022
@byroot byroot deleted the sql-assertions branch February 19, 2022 08:23
@byroot byroot mentioned this pull request Feb 19, 2022
Closed
rafaelfranca pushed a commit that referenced this pull request Feb 25, 2022
@byroot @rafaelfranca
Merge pull request #44484 from rails/sql-assertions
991e784 
Implicitly assert no exception is raised in `assert_queries` & al
@yahonda yahonda mentioned this pull request May 16, 2022
Closed
@miquelbarba miquelbarba mentioned this pull request Aug 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
actiontext actionview activerecord activestorage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@byroot