Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed list of gems rails 7 specified in the Rails initialization guide [ci-skip] #44493

Merged
merged 1 commit into from Feb 21, 2022

Conversation

ghousemohamed
Copy link
Contributor

Summary

In the Rails Initialization Guide, the list of gems which are said to be present in a standard rails application does not reflect the current state of a standard Rails 7 application. Here's what I've updated:

  1. Removed, arel gem from the list, since it has now been moved to activerecord gem
  2. Added the following gems which are missing: bootsnap, importmap-rails, jbuilder, puma, redis, sprockets-rails, stimulus-rails, turbo-rails

Thanks!

@rails-bot rails-bot bot added the docs label Feb 20, 2022
@ghousemohamed ghousemohamed changed the title Updated list of gems rails 7 application depends on Updated list of gems rails 7 application depends on [ci-skip] Feb 20, 2022
Copy link
Member

@jonathanhefner jonathanhefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this! Overall, I'm not sure how much value this list provides. Perhaps it would be better to remove the list, so that it won't have to be updated in the future?

* rack
* rack-test
* rails
* railties
* rake
* redis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although gem "redis" is in the Gemfile, I believe it is commented out by default, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When generating a new application it does get added by default

@ghousemohamed
Copy link
Contributor Author

Thank you for looking into this! Overall, I'm not sure how much value this list provides. Perhaps it would be better to remove the list, so that it won't have to be updated in the future?

Correct, there is a bit of cognitive dissonance when reading the documentation when we are presented with a list of gems in the middle of reading. It does not add value as you said. Let me remove this list

@ghousemohamed ghousemohamed changed the title Updated list of gems rails 7 application depends on [ci-skip] removed list of gems rails 7 specified in the Rails initialization guide [ci-skip] Feb 21, 2022
@ghousemohamed ghousemohamed reopened this Feb 21, 2022
@ghousemohamed
Copy link
Contributor Author

@jonathanhefner I've removed the list as suggested.

@jonathanhefner jonathanhefner merged commit 65c1063 into rails:main Feb 21, 2022
@jonathanhefner
Copy link
Member

jonathanhefner commented Feb 21, 2022

Great! Thank you, @ghousemohamed! 👍

Backported to 7-0-stable in eccc782.

jonathanhefner added a commit to jonathanhefner/rails that referenced this pull request Feb 21, 2022
removed list of gems rails 7 specified in the Rails initialization guide [ci-skip]

(cherry picked from commit 65c1063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants