Remove assets.enabled from Configuring guide #44525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option was removed in rails#18636 and didn't make the cut to the gem (since loading the gem enables the asset pipeline).
|
Thank you, @etiennebarrie! (Just to clarify, this was also removed from
Rails changes the default value of one of these options, and it is possible that we may change others in the future. I think it would be good to keep this section, so that we have a place to document such default values. (Backported to |
jonathanhefner
added a commit
that referenced
this pull request
Feb 23, 2022
…om-configuring-guide Remove assets.enabled from Configuring guide [ci-skip] (cherry picked from commit 19f8d03)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option was removed in #18636 and didn't make the cut to the gem (since loading the gem enables the asset pipeline).
Summary
Removes a nonexistent configuration option from the Configuring guide.
Other Information
Should we remove the whole
assetssection since it's optional now? The configuration options are well documented in the gem itself so we could point there.