Rollback nested transactions by restarting the parent where possible #44526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not a common operation, but still, no point running two queries when one will do.
matthewd
force-pushed
the
restart-transaction
branch
from
d8be47c
to
19e0f67
Compare
This allows us to simulate an immediately-nested transaction without ever needing to begin or commit the child: those operations are no-ops, and we need only run a command if the child rolls back. Further, we can use a single query to implement that rollback: where the parent is a savepoint, the standard behaviour is to roll back to immediately _after_ the savepoint was set. Where the parent is a top-level transaction, most databases support ROLLBACK AND CHAIN.
matthewd
force-pushed
the
restart-transaction
branch
from
19e0f67
to
3f19431
Compare
This was referenced Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to simulate an immediately-nested transaction without ever needing to begin or commit the child: those operations are no-ops, and we need only run a command if the child rolls back.
Further, we can use a single query to implement that rollback: where the parent is a savepoint, the standard behaviour is to roll back to immediately after the savepoint was set. Where the parent is a top-level transaction, most databases support
ROLLBACK AND CHAIN.