Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Various Action View tests randomly fail with errors like the following:
Here's an example of a failing build: https://buildkite.com/rails/rails/builds/84207#3bc8eb7f-c86d-4f6f-8932-e2e8c26cf893
A number of test classes use
ActionView::LookupContext::DetailsKey.clear
in theirsetup
method to clear out a cache before executing tests, but the failing test classes do not have this. Adding it eliminates the failures. After making these changes, I ran the test suite in a loop (while bundle exec bin/test; do :; done
) for 12 hours and did not observe any failures.Note: I don't understand the details of the caching mechanism that's at play here, so I'm not certain that this is the best fix. I noticed some past PRs for flaky tests that could be related: