Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify adapter construction; defer connect until first use #44591

Merged
merged 8 commits into from
Jul 29, 2022
Merged

Simplify adapter construction; defer connect until first use #44591

merged 8 commits into from
Jul 29, 2022

Commits on Jul 29, 2022

  1. Simplify adapter construction; defer connect until first use

    @matthewd
    matthewd committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    8551e64 View commit details
    Browse the repository at this point in the history

  2. Ensure a lost connection upon COMMIT fails "cleanly" 

    There's no point attempting to rollback in this case; we can instead
just invalidate the now-lost transaction.

Similarly, even though we can't immediately reconnect for a connection
failure mid-transaction, we can and should drop and prior verification
of the connection: the next out-of-transaction query attempt needs to
fix it, not assume it's working.
    @matthewd
    matthewd committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    0e92677 View commit details
    Browse the repository at this point in the history

  3. Configure legacy-API-supplied connection before first use

    @matthewd
    matthewd committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    deec300 View commit details
    Browse the repository at this point in the history

  4. Non-retryable exceptions also break connection verification

    @matthewd
    matthewd committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    fe2846a View commit details
    Browse the repository at this point in the history

  5. We're still inside the transaction until the ROLLBACK has run 

    This previously made no difference, but it now saves us reconnecting to
run a ROLLBACK: because we're still inside a transaction at that moment,
we won't be #restorable?.
    @matthewd
    matthewd committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    d56188d View commit details
    Browse the repository at this point in the history

  6. Drop default retry count to 1 

    This is enough to enable basic recovery for everyone by default, while
leaving more time-consuming repeated attempts for those who configure
them.
    @matthewd
    matthewd committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    0223967 View commit details
    Browse the repository at this point in the history

  7. Be a bit clearer in the new-adapter-API argument error

    @matthewd
    matthewd committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    e4193de View commit details
    Browse the repository at this point in the history

  8. Don't expect rollback to cause a reconnect

    @matthewd
    matthewd committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    91a3a2d View commit details
    Browse the repository at this point in the history