Mime Support for "problem detail" #44608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what the "RootLess" test variants denote but that one fails where the other passes so I have removed it - maybe a reviewer can specify if that is important. |
|
I think this PR is totally fine. That said, I read through the PRs that you linked to for context, and I'm not really clear what's going on in those PRs so I don't get why it was reverted 😅 From what I understand, Anyway, I'm going to merge this but I just wanted to write down what I was thinking as I reviewed the PR. Thanks for the work! |
|
Awesome! Thanks for the review and merge. |
pixeltrix
added a commit
to pixeltrix/rails
that referenced
this pull request
Mar 20, 2022
In rails#44608 the application/problem+json content type was added as a default alias for json but as the test only fails intermittently it wasn't picked up during PR review. It also restores the rootless test that was reverted due to it failing for the same reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RFC7807 defines a "problem detail" as
The spec is somewhat irrelevant, but due to the extended content type Rails does not recognize
application/problem+jsonas JSON (particularly when parsing test Response bodies). This PR proposes adding it as an additional recognized Mime subtype forapplication/jsonOther Information
The largest counterpoint I can think of is the previous addition and removal of
application/vnd.api+json(see #23712). Unlikevnd.api+json,problem_jsonis an RFC-specific format that is universal - not vendor-specific - and native support would add lots of value to Rails API projects.