remove extra core_ext/object/blank requires #44694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
activerecord/lib/active_record/connection_adapters/postgresql/column.rb - usage added in 64fd666 - unneeded because of active_support/rails: 8f58d6e railties/lib/rails/rack/logger.rb - usage added in c83d9a1 - usage removed in c131211 activesupport/lib/active_support/number_helper/number_converter.rb - the NumberHelper was split into multiple classes in 2da9d67, however the require was left in NumberConverter even though NumberToPhoneConverter is the only class where it's used activesupport/lib/active_support/duration/iso8601_serializer.rb - usage added in 04c512d - usage removed in 51e991f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
activerecord/lib/active_record/connection_adapters/postgresql/column.rbrailties/lib/rails/rack/logger.rbactivesupport/lib/active_support/number_helper/number_converter.rbthe require was left in NumberConverter even though
NumberToPhoneConverter is the only class where it's used
activesupport/lib/active_support/duration/iso8601_serializer.rb