Removed unwanted code which sets session host in console mode #44748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghousemohamed
force-pushed
the
remove-setting-session-host-in-console
branch
from
9d0f09e
to
d525788
Compare
st0012
added a commit
to Shopify/rails
that referenced
this pull request
May 3, 2024
After rails#44748, the `new_session` helper no longer takes a block and is the same as calling `app(true)`. Therefore, I think there's no reason to expose it to Rails console users.
4 tasks
st0012
added a commit
to Shopify/rails
that referenced
this pull request
May 3, 2024
After rails#44748, the `new_session` helper no longer takes a block and is the same as calling `app(true)`. Therefore, I think there's no reason to expose it to Rails console users.
st0012
added a commit
to Shopify/rails
that referenced
this pull request
May 6, 2024
After rails#44748, the `new_session` helper no longer takes a block and is the same as calling `app(true)`. Therefore, I think there's no reason to expose it to Rails console users.
st0012
added a commit
to Shopify/rails
that referenced
this pull request
May 7, 2024
After rails#44748, the `new_session` helper no longer takes a block and is the same as calling `app(true)`. Therefore, I think there's no reason to expose it to Rails console users.
st0012
added a commit
to Shopify/rails
that referenced
this pull request
May 15, 2024
After rails#44748, the `new_session` helper no longer takes a block and is the same as calling `app(true)`. Therefore, I think there's no reason to expose it to Rails console users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Setting the session host for the app instance in the following way for console mode is
not needed.
rails/railties/lib/rails/console/app.rb
Lines 12 to 14 in 61d6eb1
The default host is already being set in
ActionDispatch::Testing::Integration, which isthe session class that is being used by the app instance.
rails/actionpack/lib/action_dispatch/testing/integration.rb
Lines 84 to 86 in 61d6eb1
The session class that is being used by the app instance:
rails/railties/lib/rails/console/app.rb
Line 21 in 61d6eb1