Update source of secret_key_base in cookie rotator example
#44862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`secrets.secret_key_base` can be one of the many different places where `secret_key_base` is set and therefore it might not work with your application. Updating the docs to use `Rails.application.secret_key_base` fixes the issue. Rails `secret_key_base` - [docs](https://api.rubyonrails.org/classes/Rails/Application.html#method-i-secret_key_base)
|
Thank you, @jackscotti! 🎉 Backported to |
jonathanhefner
added a commit
that referenced
this pull request
Apr 13, 2022
Update source of `secret_key_base` in cookie rotator example [ci-skip] (cherry picked from commit 98b8b0d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
secrets.secret_key_basecan be one of the many different places wheresecret_key_baseis set and therefore it might not work with your application.Updating the docs to use
Rails.application.secret_key_basefixes the issue.Rails
secret_key_base- docs