Use immutable URL for arbitrary code #44985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `client9/misspell` repo is compromised, an attacker could control the contents of `install-misspell.sh`. Since we execute that file directly, we should use a URL that guarantees its contents will not change. Note that, at the time of writing, the last commit to `client9/misspell` was in March 2018 (client9/misspell@c0b55c8), so the code appears to be stable. Also, although using a tag would be prettier than using a hash, the repo's last commit is after its most recent tag (`v0.3.4`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
client9/misspellrepo is compromised, an attacker could control the contents ofinstall-misspell.sh. Since we execute that file directly, we should use a URL that guarantees its contents will not change.Note that, at the time of writing, the last commit to
client9/misspellwas in March 2018 (client9/misspell@c0b55c8), so the code appears to be stable.Also, although using a tag would be prettier than using a hash, the repo's last commit is after its most recent tag (
v0.3.4).