Fix Inconsistent ActiveRecord insert_all! Interfaces

[berniechiu]

Summary

Currently the method insert_all! is missing the arguments to apply unique_by in cases when we need to use them, not sure why it has the inconsistent interface for calling with ! besides raising error, they should share the same argument interface.

Other Information

[eileencodes]

I was reading the original PR and the current documentation and I think that this doesn't support unique_by on purpose. The reason insert_all! exists is to raise if any inserts would violate a unique constraint on the table. By accepting a unique_by option, it defeats the purpose of insert_all!. I think in this case you're supposed to use insert_all instead.

If we do decide to accept this PR it needs tests.

[eileencodes]

This changelog should be in activerecord/CHANGELOG.md not in Railties.

I also think it should say "ActiveRecord::Persistence::ClassMethods#insert_all! now supports the unique_by option" and include an example of usage.

[berniechiu]

Thanks for the heads up

[berniechiu]

Should be updated by now : )

[berniechiu]

The counterparts are here that don't raise any error

But actually, it's supported and we're actually logging our custom message in my company.

rails/activerecord/test/cases/insert_all_test.rb

Lines 121 to 142 in 6cda769

	def test_insert_all_can_skip_duplicate_records
	skip unless supports_insert_on_duplicate_skip?
	assert_no_difference "Book.count" do
	Book.insert_all [{ id: 1, name: "Agile Web Development with Rails" }]
	end
	end
	def test_insert_all_with_skip_duplicates_and_autonumber_id_not_given
	skip unless supports_insert_on_duplicate_skip?
	assert_difference "Book.count", 1 do
	# These two books are duplicates according to an index on %i[author_id name]
	# but their IDs are not specified so they will be assigned different IDs
	# by autonumber. We will get an exception from MySQL if we attempt to skip
	# one of these records by assigning its ID.
	Book.insert_all [
	{ author_id: 8, name: "Refactoring" },
	{ author_id: 8, name: "Refactoring" }
	]
	end
	end