Skip association validation when the record is persisted, unchanged and invalid #45355
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
reviewed
Oct 13, 2022
| @@ -329,6 +329,7 @@ def validate_collection_association(reflection) | |||
| # enabled records if they're marked_for_destruction? or destroyed. | |||
| def association_valid?(reflection, record, index = nil) | |||
| return true if record.destroyed? || (reflection.options[:autosave] && record.marked_for_destruction?) | |||
| return true if !custom_validation_context? && record.persisted? && !record.has_changes_to_save? && !record.valid? | |||
There was a problem hiding this comment.
The autosave code is very complex with a lot of conditionals.
I'm wondering if this should be handled instead in
rails/activerecord/lib/active_record/autosave_association.rb
Lines 279 to 287 in 34b905d
There was a problem hiding this comment.
I think it has to be done in association_valid? because we need to skip validation but keep it for saving.
I noticed that !record.valid? is not necessary.
Maybe that helps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #45320
This adds consistency to the behavior described in the issue. Basically, skips validation when the associated record is persisted, unchanged and invalid.