Improve ActiveRecord::QueryMethods.readonly doc [skip ci] #45654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
requested changes
Sep 6, 2022
shouichi
changed the title
> Sets readonly attributes for the returned relation. The current documentation gives the impression that it can manipulate `attr_readonly`. Co-authored-by: Petrik de Heus <petrik@deheus.net>
shouichi
force-pushed
the
improve-readonly-doc
branch
from
df6f0a3
to
cdbbb96
Compare
|
@p8 Committed your suggested changes and squashed commits. Could you take a look again? (Sorry for the late reply. I missed your reply.) |
|
Thanks @shouichi 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation gives the impression that it can manipulate
attr_readonly.