Delegate valid_encoding? for ActionView::OutputBuffer #45673
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ActionView::OutputBuffer#valid_encoding?
as a delegated method.ActionView::OutputBuffer
used to inherit fromActiveSupport::SafeBuffer
, which itself inherits fromString
, so it used to expose all public String methods. This was refactored as part of #45614, however I don't think that leaving out some string methods was intentional (it already delegates some of them).We have encoding validation checks at GitHub so I think exposing what the encoding is (
encoding
) and whether it's valid (valid_encoding?
) would be reasonable and something we need. 馃槂