Fix default SameSite for session cookies
#45688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to rails#45501. The Rack base class that `CookieStore` inherits from [always sets `:same_site`][1]. Thus, `options.key?(:same_site)` always returns true for session cookies, preventing a default value from being set. It would be possible to change Rack to conditionally set `:same_site`, but, from Rack's perspective, it has no reason to not set `:same_site`, because it treats a `nil` value the same as no value. Therefore, this commit specifies a default `:same_site` in `CookieStore`, which simply defers to `request.cookies_same_site_protection` as `CookieJar` does. Fixes rails#45681. [1]: https://github.com/rack/rack/blob/2.2.4/lib/rack/session/abstract/id.rb#L398-L402
jonathanhefner
force-pushed
the
session-cookies-default-same_site
branch
from
19dfab3
to
c95780d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #45501.
The Rack base class that
CookieStoreinherits from always sets:same_site. Thus,options.key?(:same_site)always returns true for session cookies, preventing a default value from being set.It would be possible to change Rack to conditionally set
:same_site, but, from Rack's perspective, it has no reason to not set:same_site, because it treats anilvalue the same as no value.Therefore, this commit specifies a default
:same_siteinCookieStore, which simply defers torequest.cookies_same_site_protectionasCookieJardoes.Fixes #45681.