Refactor Action View tests to stop re-assigning @output_buffer #45748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
commented
Aug 3, 2022
| @@ -17,7 +17,7 @@ module Context | |||
| # Prepares the context by setting the appropriate instance variables. | |||
| def _prepare_context | |||
| @view_flow = OutputFlow.new | |||
| @output_buffer = nil | |||
| @output_buffer = ActionView::OutputBuffer.new | |||
There was a problem hiding this comment.
This isn't a test only change, but I think it's for the best. The goal ultimately is to stop swapping the buffer, so ultimately allocating it when the context is allocated will make sense.
casperisfine
force-pushed
the
action-view-refactor-output-buffer-test-2
branch
from
08defaa
to
2a492b7
Compare
Followup on rails#45745 `@rendered` is a much better variable for this kind of intermediate result as that's what is used by DOM assertions.
casperisfine
force-pushed
the
action-view-refactor-output-buffer-test-2
branch
from
2a492b7
to
4b67dff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #45745
@renderedis a much better variable for this kind of intermediate result as that's what is used by DOM assertions.FYI: @jhawthorn, @BlakeWilliams (I'll merge on green)