Show BCC field in mailer preview #45935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-spectator
force-pushed
the
add_bcc_to_mailer_preview
branch
2 times, most recently
from
2f4c815
to
bfcb40f
Compare
|
I think this will need a changelog entry in railties, other than that it looks good to me |
the-spectator
force-pushed
the
add_bcc_to_mailer_preview
branch
from
bfcb40f
to
170edd5
Compare
the-spectator
force-pushed
the
add_bcc_to_mailer_preview
branch
from
170edd5
to
f44362b
Compare
|
Looks good! Also, this seems to be the only header from the Thank you, @the-spectator! 👍 |
|
Thank you for the merge @jonathanhefner @skipkayhil 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds BCC field value in the mailer preview when the
bccvalue is available.Other Information