Fix GH #4344. Callback defined in a module is not triggered when the module extends an object under Rails 3.2rc2 #4596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josevalim There are this issue on Rails master and 3-2-stable |
| @@ -359,7 +359,7 @@ module ClassMethods | |||
| def __run_callbacks(key, kind, object, &blk) #:nodoc: | |||
| name = __callback_runner_name(key, kind) | |||
| unless object.respond_to?(name) | |||
| str = send("_#{kind}_callbacks").compile(key, object) | |||
| str = object.class_eval { send("_#{kind}_callbacks").compile(key, object) } | |||
There was a problem hiding this comment.
Are you sure that:
object.send("_#{kind}_callbacks").compile(key, object)Not gonna work here?
There was a problem hiding this comment.
Awesome!
It's work fine. It seems that it was mistaken how to fix.
We just call the method that belongs to object's eigen class
I'll squash and push.
|
Looks good, thanks @kennyj |
|
@josevalim Please confirm this PR. If we should merge this to 3-2-stable, I could send PR again. |
josevalim
added a commit
that referenced
this pull request
Jan 24, 2012
Fix GH #4344. Callback defined in a module is not triggered when the module extends an object under Rails 3.2rc2
|
Actually, don't worry. I will backport this to 3-2-stable myself. |
|
Please sanity check: dc826f9 |
|
No problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this issue is introduced 66a587c.
Callbacks is compiled at different timing and context.
In 3.2.0.rc1
callbacks often is compiled in __define_runner method.
In 3.2.0.rc2
callbacks always is compiled in __run_callback method.
Please see also #4344
/cc @bogdan