Remove QueAdapter from Active Job #46005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Que and Rails (Active Job QueAdapter) have applied changes each other to support Ruby 3 keyword arguments and options provided as top level keywords, etc via these commits: rails#44734 rails#44248 que-rb/que@d9244b9 via que-rb/que#319 Finally, we've found it is quite difficult to maintain them. Going forward Active Job Que adapter can be included in the future version of que gem itself. Refer to rails#45899 the background for this change. Active Job Que adapter can be included in the future version of que gem itself.
rafaelfranca
approved these changes
Sep 12, 2022
ZimbiX
added a commit
to que-rb/que
that referenced
this pull request
Oct 9, 2023
This no longer exists in Rails, but is still needed. I simply copied the class from the [removal PR](rails/rails#46005), and removed the unnecessary comments, and adjusted the formatting slightly. (Tests not yet passing)
maxschridde1494
pushed a commit
to talysto/que
that referenced
this pull request
Oct 24, 2023
This no longer exists in Rails, but is still needed. I simply copied the class from the [removal PR](rails/rails#46005), and removed the unnecessary comments, and adjusted the formatting slightly. (Tests not yet passing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Que and Rails (Active Job QueAdapter) have applied changes each other to support Ruby 3 keyword arguments and options provided as top level keywords, etc via these commits:
#44734
#44248
que-rb/que@d9244b9 via que-rb/que#319
Finally, we've found it is quite difficult to maintain them. Going forward Active Job Que adapter can be included in the future version of que gem itself. Refer to #45899 the background for this change.
Active Job Que adapter can be included in the future version of que gem itself.
Detail
This Pull Request removes QueAdapter from Active Job.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]main(if not - rebase it).