Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid redundant fetch blocks #46167

Closed
wants to merge 1 commit into from
Closed

Avoid redundant fetch blocks #46167

wants to merge 1 commit into from

Conversation

coorasse
Copy link
Contributor

fetch supports a fallback value as second argument.

Motivation / Background

standardrb and rubocop complain about Style/RedundantFetchBlock.

@coorasse
Avoid redundant fetch blocks
323ee74 
`fetch` supports a fallback value as second argument.
@rails-bot rails-bot bot added the railties label Sep 30, 2022
@p8
Copy link
Member

p8 commented Oct 1, 2022 •
edited

Hey @coorasse, thanks for the PR.
A similar PR was closed for the following reason:

We have no interest in following the moving, and potentially conflicting, targets of various third party linters.

#42449 (comment)

So I'll close this one as well. Sorry.

@p8 p8 closed this Oct 1, 2022
@zzak zzak mentioned this pull request Sep 13, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
railties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coorasse @p8