Add ActiveModel::Attributes#==. #46517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix it in lint later. |
I want to be able to compare identity checks with == method. Because I want to compare attribute identities, but currently I have to go through the attribute method. I wanted to use AttributeSet#== for the comparison to avoid creating unnecessary objects, but since it does not return true if the value before type cast are different, I used Attributes#attributes instead. ```ruby # before UserModel.new(id: 1) == UserModel.new(id: 1) # false # after UserModel.new(id: 1) == UserModel.new(id: 1) # true ``` *aaasa*
bonobono555
force-pushed
the
add_equal_method_to_activemodel_attributes
branch
from
07da7dc
to
9b73de4
Compare
rafaelfranca
requested changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
I want to be able to compare identity checks with == method. Because I want to compare attribute identities,
but currently I have to go through the attribute method.
Detail
Additional information
I wanted to use AttributeSet#== for the comparison to avoid creating unnecessary objects, but since it does not return true if the value before type cast are different, I used Attributes#attributes instead.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]