Scope generated route helpers to an instance of RoutesProxy #46974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because
RoutesProxy
caches route helpers within its class usingself.class.class_eval(...)
. For example if two engineWeblog::Engine
andMetrics::Engine
are mounted within your app and only weblog defines the route helperweblogs_path
callingmetrics.respond_to?(:weblogs_path)
will return true if previouslyweblog.weblogs_path
has been called.Detail
This Pull Request changes
self.class.class_eval(...)
toinstance_eval(...)
so route helpers are cached within the instanced object instead of the class so they are not shared by all instances.Additional information
I would love to get feedback if there is a better way to test this.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]