Backport #45745 #47050
Merged
Backport #45745 #47050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's really not what it's meant for. `@renderer` is a better use for this as it's the variable used by the DOM testing helpers. Ref: rails#45731
skipkayhil
referenced
this pull request
Jan 19, 2023
FormBuilder#id finds id set by `form_for` & `form_with`
|
Failing spellcheck fixed in #47051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes
7-0-stabletests failing since a3d3851Detail
The commit did not cherry-pick cleanly because it changed a test added in c92ac83, so I fixed the conflict
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number][ ] Tests are added or updated if you fix a bug or add a feature.[ ] CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.