Improve matching of cookie assertions. #47066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
rack-3-cookies
branch
from
8a6fad6
to
f3cb9b8
Compare
The current implementation makes assumptions about the order and case sensitivity of cookie attributes. Introduce methods to parse those fields and compare them semantically. Update the existing tests to take advantage of these new assertions.
ioquatix
force-pushed
the
rack-3-cookies
branch
from
f3cb9b8
to
f63a5e7
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation makes assumptions about the order and case sensitivity of cookie attributes. Introduce methods to parse those fields and compare them semantically. Update the existing tests to take advantage of these new assertions.
This is in preparation for Rack 3 which requires these changes, since it generates cookies using lower case tokens, while Rack 2 used mixed case.