Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated Rack::File with Rack::Files #47094

Merged
merged 1 commit into from Jan 25, 2023
Merged

Replace deprecated Rack::File with Rack::Files #47094

merged 1 commit into from Jan 25, 2023

Conversation

zzak
Copy link
Member

@zzak zzak commented Jan 21, 2023

Follow up to #47075

/cc @ioquatix

@ioquatix
Copy link
Contributor

LGTM.

@ioquatix
Copy link
Contributor

Since I missed this, it might mean we are missing test coverage.

@ioquatix ioquatix mentioned this pull request Jan 21, 2023
Closed
@ioquatix
Copy link
Contributor

cc @rafaelfranca this should be easy to merge.

ioquatix
ioquatix reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rafaelfranca rafaelfranca merged commit e572f23 into rails:main Jan 25, 2023
@zzak zzak deleted the rack-3-files-continued branch January 26, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioquatix ioquatix ioquatix left review comments

Assignees
No one assigned
Labels
actionpack activestorage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zzak @ioquatix @rafaelfranca