Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove changelog entry for bugfix [#46300] #47097

Merged
merged 1 commit into from Jan 21, 2023
Merged

Conversation

zzak
Copy link
Member

@zzak zzak commented Jan 21, 2023

We usually only put features / major changes in the changelog

ref: #46879 (comment)

Also mentioned here:
https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#updating-the-changelog

You should add an entry to the top of the CHANGELOG of the framework you modified if you're adding or removing a feature, or adding deprecation notices. Refactorings, minor bug fixes, and documentation changes generally should not go to the CHANGELOG.

We usually only put features / major changes in the changelog

ref: rails#46879 (comment)
@p8 p8 merged commit 8602a86 into rails:main Jan 21, 2023
@zzak zzak deleted the rm-bugfix-changelog branch January 21, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants