Gracefully degrade when ActionMailer::Base#params
is nil
#47101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Prior to this change, access to
params
onActionMailer::Base
instances prior to being decorated byActionMailer::Parameterized.with
calls results in aNoMethodError
:Detail
This change modifies the
attr_accessor :params
to be anattr_writer
paired with aparams
method that assigns@params
to an emptyHash
whenever it's accessed without being otherwise initialized.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]