Add HTTP::Request#route_uri_pattern that returns URI pattern of matched route. #47129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,6 +57,8 @@ def self.empty | |||
| new({}) | |||
| end | |||
|
|
|||
| attr_accessor :route_uri_pattern | |||
There was a problem hiding this comment.
We should implement this using the rack env so middleware can also have access to the information. See routes= for example.
joelhawksley
force-pushed
the
current-route
branch
from
79d6fd8
to
4f1c20b
Compare
|
@rafaelfranca thanks for the suggestions in your review. I've updated the PR accordingly ❤️ |
| @@ -153,6 +153,14 @@ def routes=(routes) # :nodoc: | |||
| set_header("action_dispatch.routes", routes) | |||
| end | |||
|
|
|||
| def route_uri_pattern # :nodoc: | |||
There was a problem hiding this comment.
Suggested change
| def route_uri_pattern # :nodoc: | |
| def route_uri_pattern |
We want this method to be public API so we need to document it.
joelhawksley
force-pushed
the
current-route
branch
from
8b5b037
to
88346fc
Compare
In the GitHub RoR monolith, we output the route URI pattern in an HTML meta tag in our application layout for analysis purposes. However, our current implementation is quite manual. This change adds an attribute to requests with the URI pattern of the matched route. Co-authored-by: Kate Higa <khiga8@github.com>
joelhawksley
force-pushed
the
current-route
branch
from
cf76b0a
to
3e63c4b
Compare
joelhawksley
changed the title
zzak
reviewed
Feb 8, 2023
| get_header("action_dispatch.route_uri_pattern") | ||
| end | ||
|
|
||
| def route_uri_pattern=(pattern) # :nodoc: |
There was a problem hiding this comment.
@joelhawksley I've opened #47306 but I was thinking we might want to add a test for this if possible? WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
In the GitHub RoR monolith, we output the route URI pattern in an HTML meta tag in our application layout for analysis purposes. However, our current implementation is quite manual.
Detail
This change adds an attribute to requests with the URI pattern of the matched route.
Additional information
Co-authored-by: Kate Higa khiga8@github.com
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]