Use Gemfile to manage Rack version for development #47133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2023
|
I like this solution but I don't have a strong opinion which one we ultimately use going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #47120.
The downside to this approach is that anyone installing
actionpackfrom the main branch will probably(?) get Rack v3, which isn't fully compatible yet. Depending on #46594. As well as, once this change is released, any new installs (or bundle update) will grab Rack 3 as well, which may have other side-effects. For example, if they're mounting another non Rack 3 compatible library such as Sinatra (TBD?), or depending on other Rack 2 specific middleware, etc.An example build can be found here:
https://buildkite.com/rails/rails/builds/93029#0185e6dd-f7da-4149-b11a-fa1a29ef38f0
This depends on rails/buildkite-config#34 to actually test different Rack versions in CI.