Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve assert_broadcast_on error message #47204

Merged

Conversation

StephaneRob
Copy link
Contributor

Motivation / Background

This Pull Request has been created to improve error message when using assert_broadcast_on. Indeed it easier to debug if the error message contains messages that have been broadcasted (or information that there is no message at all)
See #47202

Detail

This Pull Request changes the assert_broadcast_on error message to display messages that have been broadcasted to a given channel

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@StephaneRob StephaneRob force-pushed the feat-improve-assert-broadcast-on-message branch from 390d8ea to 7723564 Compare January 31, 2023 18:59
@StephaneRob StephaneRob changed the title feat: improve assert_broadcast_on error message feat: improve assert_broadcast_on error message Feb 2, 2023
@StephaneRob StephaneRob force-pushed the feat-improve-assert-broadcast-on-message branch from 7723564 to 1333260 Compare February 4, 2023 18:48
@byroot byroot merged commit 3d0d027 into rails:main Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants