Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full refresh of framework dummy applications #47259

Merged
merged 6 commits into from Mar 1, 2023
Merged

Full refresh of framework dummy applications #47259

merged 6 commits into from Mar 1, 2023
+790 −8,329

Commits on Feb 18, 2023

  1. Regenerate Action Mailbox dummy app 

    Generated using the following script and manually reviewed after:
skipkayhil/rails-bin@6898611

The :messages route was removed because there isn't actually a
MessagesController.

config/boot.rb also has its Gemfile path fixed to point at the root
Gemfile because Action Mailbox does not have a Gemfile.
    @skipkayhil
    skipkayhil committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    0e3a533 View commit details
    Browse the repository at this point in the history

  2. Remove Webpacker files in Action Mailbox dummy app 

    Similar to 89a24d6, but importmaps are
not added because no javascript is used in the app
    @skipkayhil
    skipkayhil committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    915159f View commit details
    Browse the repository at this point in the history

  3. Regenerate Action Text dummy app 

    Generated using the following script and manually reviewed after:
skipkayhil/rails-bin@38e2aac
    @skipkayhil
    skipkayhil committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    9795eb9 View commit details
    Browse the repository at this point in the history

  4. Remove Webpacker files in Action Text dummy app 

    These are leftover after Webpacker was replaced with importmaps in
89a24d6
    @skipkayhil
    skipkayhil committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    2e5d060 View commit details
    Browse the repository at this point in the history

  5. Regenerate Active Storage dummy app 

    Generated using the following script and manually reviewed after:
skipkayhil/rails-bin@cbad7ed

The active_storage configuration had to be moved to the dummy app
because of the changed eager_load config. Now, the whole app is eagerly
loaded when the app's environment file is required which means that
changing configuration in the test_helper is too late.
    @skipkayhil
    skipkayhil committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    11c59f7 View commit details
    Browse the repository at this point in the history

  6. Remove unused js files in Active Storage dummy app

    @skipkayhil
    skipkayhil committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    23a459b View commit details
    Browse the repository at this point in the history