Refactor ViewPath::Registry into path ActionView::PathRegistry #47487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickborromeo
force-pushed
the
refactor-viewpath-registry-into-path-registry
branch
from
00af078
to
075d6e9
Compare
jhawthorn
reviewed
Feb 24, 2023
This is a refactor of the `Registry` module added in rails#47347. This is an attempt to minimize the namespace conflcits that will happen when users will have a top level `Registry` module which can cause incorrect behavior Replace ActionView::ViewPaths::Registry with ActionView::PathRegistry
nickborromeo
force-pushed
the
refactor-viewpath-registry-into-path-registry
branch
from
075d6e9
to
92216eb
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
In #47347
ActionView::ViewPath::Registrywas introduced. In a recent upgrade to rails, we found that this change conflicted with a top level module calledRegistry. Instead of fixing the changes locally, it was suggested by @matthewd that we fix the namespace conflicts upstream instead.Detail
This moves the
Registrymodule underViewPathinto its own module underActionViewcalledPathRegistry. Functionally there should be no change in the changes introduced in #47347.