Apply rails 3.2 patch for activemodel attribute access #47509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because the fix for CVE-2013-0276 was never applied fully to Rails 4 and later.
It is a cherry-pick adjusted for the current state of the code to give proper authorship credits.
Original commit:
Detail
This Pull Request changes the attribute matching in activemodel. Newlines will now be seen as part of the attribute name, thus making injections harder.
Additional information
This was originally easy to exploit but the switch to strong parameters should make it a non-issue in most cases.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]