Fix Fanout thread safety #47736
Merged
Fix Fanout thread safety #47736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fanout is a singleton shared among threads, so all of its hash maps should be concurrent hash maps otherwise we'll see errors like this: ``` RuntimeError: can't add a new key into hash during iteration ```
|
@zenspider if this fixes your production issues please lmk! |
|
Should this use |
|
We're deploying our monkeypatch to prod now... I'll let you know. |
|
Confirmed! |
Yeah, shouldn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fanout is a singleton shared among threads, so all of its hash maps should be concurrent hash maps otherwise we'll see errors like this:
cc @zenspider