Ensure that ids_writer and ids_reader is working for CPK #47925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes `ids_writer` so that it can handle a composite primary key. Using a CPK model associated with a non-CPK model was working correctly (which I added a test for). Using a CPK model associated with another CPK model was not working correctly. It now takes it into account to write the correct ids. While working on `ids_reader` I found that `pluck` is not working for CPK because it's passing an array of attributes and that's not supported by `disallow_raw_sql!`. I chose to call `flatten` in `pluck` but not conditionally because this seems like it could be a problem elsewhere as well. This fixes pluck by CPK overall and fixes a test in the calculations test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
ids_writerso that it can handle a composite primary key. Using a CPK model associated with a non-CPK model was working correctly (which I added a test for). Using a CPK model associated with another CPK model was not working correctly. It now takes it into account to write the correct ids.While working on
ids_readerI found thatpluckis not working for CPK because it's passing an array of attributes and that's not supported bydisallow_raw_sql!. I chose to callflatteninpluckbut not conditionally because this seems like it could be a problem elsewhere as well. This fixes pluck by CPK overall and fixes a test in the calculations test file.cc/ @nvasilevski @paarthmadan