Better deprecation warning for ActiveSupport::Deprecation.warn
#47978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: rails#47354 (comment) It is common to see this code in apps (not in gems/engines, but in user code): ```ruby ActiveSupport::Deprecation.warn "foo" ``` Currently that code will emit this warning: > DEPRECATION WARNING: Calling warn on ActiveSupport::Deprecation is deprecated and will be removed from Rails (use your own Deprecation object instead) This PR changes the warning so that it gives you more direct advice on how to fix it: > DEPRECATION WARNING: Calling warn on ActiveSupport::Deprecation is deprecated and will be removed from Rails (use `ActiveSupport.deprecator.warn` instead) My understanding is that this is fine for user code, and we are not expecting users to define their own deprecators for in-app use. Given that, we should just tell the user what to do in the error message.
4 tasks
|
I'm not sure about this one. I think if a Rails application is complex enough that it's emitting its own deprecation warnings it should define its own Deprecator so that it can control when those warnings will raise/warn/log/etc. separately from the rest of Active Support. Otherwise we effectively have the previous behavior where all deprecations go through the same class. Edit: Very related: #46583 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #47354 (comment)
It is common to see this code in apps (not in gems/engines, but in user code):
Currently that code will emit this warning:
This PR changes the warning so that it gives you more direct advice on how to fix it:
My understanding is that this is fine for user code, and we are not expecting users to define their own deprecators for in-app use. Given that, we should just tell the user what to do in the error message.