Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active storage proxy setting filename #47984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neudabei
Copy link

Motivation / Background

The current version of the guides states that we can set proxying for ActiveStorage. However, it mentions that this is set in config/initializers/active_storage.rb

This file does not seem to exist, so I suggest that this config is set in one of the environment files. In the case of proxying it makes sense to set this in config/environments/production.rb.

Alternatively it could be set in config/application.rb

This Pull Request has been created because it fixes a small error in the ActiveStorage guides.

Detail

This Pull Request changes config/initializers/active_storage.rb to config/environments/production.rb in https://edgeguides.rubyonrails.org/active_storage_overview.html#proxy-mode

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

The current version of the guides states that we can set proxying for
ActiveStorage. However, it mentions that this is set in
config/initializers/active_storage.rb

This file does not seem to exist, so I suggest that this config is set
in one of the environment files. In the case of proxying it makes sense
to set this in config/environments/production.rb.

Alternatively it could be set in config/application.rb
@rails-bot rails-bot bot added the docs label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant