Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guides top navigation like Rails homepage #48064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

p8
Copy link
Member

@p8 p8 commented Apr 25, 2023

This makes the top navigation of guides more similar to the Rails homepage by using the same fonts, styling and logo as the Rails homepage.

The "home" and "Contribute" links in the secondary navigation are removed, as these are directly visible in the top navigation.

Before

image

image

image

After

image

image

image

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

This makes the top navigation of guides more similar to the Rails
homepage by using the same fonts, styling and logo as the Rails
homepage.

The "home" and "Contribute" links in the secondary navigation are
removed, as these are directly visible in the top navigation.
@rails-bot rails-bot bot added the docs label Apr 25, 2023
@p8 p8 changed the title Update guides top navigation Guides top navigation like Rails homepage Apr 26, 2023
@zzak
Copy link
Member

zzak commented Apr 26, 2023

Just a thought, but in the mobile screen it's hard to tell the logo is a button to open the menu IMO. I know this came up in the splash screen too and they added a drop shadow. I'm still not convinced though 🤔

@zzak
Copy link
Member

zzak commented May 19, 2023

I'd like to hear some other opinions about the "logo vs. button" thing, but another thought I had was just about the "Guides Index" feeling too long, maybe that can just always be a hamburger menu after we move the other links out?

Ideally the top navigation should be consistent across the website, api docs, and guides IMO. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants