Make Adapter#exec_query clear the query cache #48069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's public API and we can't assume whether the query is read only so we should clear the cache. To perform read only queries, `select` and `select_all` can be used.
eileencodes
added a commit
to eileencodes/rails
that referenced
this pull request
May 10, 2023
…sh-cache" This reverts commit 663df3a, reversing changes made to 9b4fff2. The changes here forced our code through a different codepath, circumventing the patch on `execute` to retry queries. Since we also patch `execute` from Semian it's not clear the correct path forward and we're going to revert for now.
eileencodes
added a commit
that referenced
this pull request
May 10, 2023
Revert "Merge pull request #48069 from Shopify/ar-exec-query-flush-cache
BuonOmo
added a commit
to cockroachdb/activerecord-cockroachdb-adapter
that referenced
this pull request
Mar 3, 2024
Follows rails changes introduced in [rails/rails#48069][rails_pr]. The `exec_query` now flushes the schema cache. As we now our queries do not alter this cache, we'd rather not flush. Might fix #320 [rails_pr]: rails/rails#48069
rafiss
pushed a commit
to cockroachdb/activerecord-cockroachdb-adapter
that referenced
this pull request
Mar 28, 2024
Follows rails changes introduced in [rails/rails#48069][rails_pr]. The `exec_query` now flushes the schema cache. As we now our queries do not alter this cache, we'd rather not flush. Might fix #320 [rails_pr]: rails/rails#48069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #48061
It's public API and we can't assume whether the query is read only so we should clear the cache.
To perform read only queries,
selectandselect_allcan be used.