Get rid of TrilogyAdapter's special errors #48109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
get-rid-of-trilogy-errors
branch
from
2cadd4a
to
bb430b7
Compare
activerecord/lib/active_record/connection_adapters/trilogy_adapter.rb
Outdated
Show resolved
Hide resolved
casperisfine
force-pushed
the
get-rid-of-trilogy-errors
branch
from
bb430b7
to
d63d192
Compare
Their value seem very limited, and I fear they cause users to rescue these specifc errors rather than the general `ConnectionFailed` one.
casperisfine
force-pushed
the
get-rid-of-trilogy-errors
branch
from
d63d192
to
cf8fe08
Compare
|
@matthewd @jhawthorn are we good to go with this one, or do you still need to do some more cleanup? |
|
Thanks for the patience on this one 😅 I'll get this merged |
|
Merged as 08d58e7 |
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Aug 4, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Aug 4, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Aug 4, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Aug 4, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Their value seem very limited, and I fear they cause users to rescue these specifc errors rather than the general
ConnectionFailedone.FYI @adrianna-chang-shopify @matthewd @jhawthorn