Scan forward until text tokens match #48294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
force-pushed
the
fix-column-info
branch
from
21fd324
to
d16f6c8
Compare
Text tokens may be conditionally appended to the output buffer. For
example if we have a template like this:
```erb
<h1>Oh no!</h1>
This template has a runtime error
<b>
<% if true %>
<%= method_that_does_not_exist %>
<% end %>
</b>
Yikes!
```
In the above case, a string literal (`" "`) will be conditionally
appended to the output buffer with some code like below:
```ruby
@output_buffer.safe_append=' '.freeze
```
This commit teaches text tokens (string literals) to scan forward in the
compiled template until it finds the literal, thereby skipping the code
generated for appending to the output buffer.
Related to:
* Bug: rails#48173
* PR: rails#48184
tenderlove
force-pushed
the
fix-column-info
branch
from
d16f6c8
to
5e35463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text tokens may be conditionally appended to the output buffer. For example if we have a template like this:
In the above case, a string literal (
" ") will be conditionallyappended to the output buffer with some code like below:
This commit teaches text tokens (string literals) to scan forward in the compiled template until it finds the literal, thereby skipping the code generated for appending to the output buffer.
Related to: