Refactor define_restrict_dependency_method using reflection #4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still an issue? |
|
@isaacsanders only a little refactor, IMHO reflects better what happening there |
| @@ -69,12 +69,12 @@ def dependent_restrict_deprecation_warning | |||
| def define_restrict_dependency_method | |||
| name = self.name | |||
| mixin.redefine_method(dependency_method_name) do | |||
| # has_many or has_one associations | |||
| if send(name).respond_to?(:exists?) ? send(name).exists? : !send(name).nil? | |||
There was a problem hiding this comment.
Is this the same as has_one_macro in the code below?
There was a problem hiding this comment.
In this commit - 336ff8a
the code is splitted in two files has_one and has_many with that condition so IMHO is the same, in some later commits we merge that code in an unique place
carlosantoniodasilva
added a commit
that referenced
this pull request
May 19, 2012
…endency_method Refactor define_restrict_dependency_method using reflection
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to know if the reflection macro is equal to has_one in two lines so I'd cached in a variable