Stop appending preload links once the head is already 1kB #48405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gklsan
reviewed
Jun 7, 2023
|
The test provides a nice idea of how many links this will append - about a dozen. My only question - this appends the first dozen links. What if those aren't the most useful ones to be appending? We always want "application.js" and "application.css" to be appended, but what if there are 15 other files before that? |
|
If you need tighter control you can do it with custom logic in the controller or a middleware. |
Fix: rails#48402 Some HTTP client and proxies have a 4kiB header limit, but more importantly including preload links has diminishing returns so it's best to not go overboard 1kB worth of preload links should be plenty.
casperisfine
force-pushed
the
refactor-preload-link-header
branch
from
225ad71
to
facc260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #48402
Some HTTP client and proxies have a 4kiB header limit, but more importantly including preload links has diminishing returns so it's best to not go overboard
1kB worth of preload links should be plenty.
cc @nateberkopec