Use cache :coder option to specify :message_pack
#48449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rails#48104, `:message_pack` was added as a supported value for the cache format version because the format version essentially specifies the default coder. However, as an API, the format version could potentially be used to affect other aspects of serialization, such as the default compression format. This commit removes `:message_pack` as a supported value for the format version, and, as a replacement, adds support for specifying `coder: :message_pack`: ```ruby # BEFORE config.active_support.cache_format_version = :message_pack # AFTER config.cache_store = :redis_cache_store, { coder: :message_pack } ```
paulreece
pushed a commit
to paulreece/rails-paulreece
that referenced
this pull request
Aug 26, 2023
Follow-up to rails#48449. Since rails#48449 changed the list of accepted cache format versions back to just `6.1`, `7.0`, and `7.1`, we can raise a more specific error.
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Sep 10, 2023
This covers rails#47770, rails#47964, rails#48103, and rails#48104, plus the follow-up changes to `ActiveSupport::Cache::Store` options from rails#48449 and rails#48451.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #48104,
:message_packwas added as a supported value for the cache format version because the format version essentially specifies the default coder. However, as an API, the format version could potentially be used to affect other aspects of serialization, such as the default compression format.This commit removes
:message_packas a supported value for the format version, and, as a replacement, adds support for specifyingcoder: :message_pack: