Improve error messages of assert_changes and assert_no_changes
#48482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcreux
force-pushed
the
improve-assert_changes-error-messages
branch
from
6ce50aa
to
40552b8
Compare
|
I think it's worth a changelog entry, there's always a chance that someone might be caught off-guard by the change for some reason and would go searching the changelogs for any mention of it. |
pcreux
force-pushed
the
improve-assert_changes-error-messages
branch
from
40552b8
to
13e6f24
Compare
|
@carlosantoniodasilva I updated the |
|
Could you please squash your commits? 🙇 |
pcreux
force-pushed
the
improve-assert_changes-error-messages
branch
from
13e6f24
to
1f6fac7
Compare
|
@zzak ✅ Done! |
|
The build failed. Retrying... |
pcreux
force-pushed
the
improve-assert_changes-error-messages
branch
from
1f6fac7
to
2879e71
Compare
|
@zzak ✅ All checks have passed. The PR is ready to merge. 💚 |
jonathanhefner
force-pushed
the
improve-assert_changes-error-messages
branch
from
3a4449b
to
2b3a002
Compare
|
I pushed a commit to rebase. Thank you, @pcreux! 🧪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Make
assert_changeserror messages show objects with.inspectto make it easier to differentiatenilfrom empty strings, strings vs symbols, etc.Make
assert_no_changeserror messages surface the actual value.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]Let me know if I should update the CHANGELOG as this is a minor change.