Rename Range#overlaps? to Range#overlap?
#48565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename for consistency with #include? and #cover?
|
https://api.rubyonrails.org/classes/Range.html#method-i-overlaps-3F |
|
@yahonda the plan is to leave both methods for 7.1 and deprecate |
|
Understood. Thanks. |
4 tasks
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Sep 19, 2023
This commit uses Ruby 3.3 `Range#overlap?` that has been added to Ruby via ruby/ruby#8242 . Rails 7.1 renames `Range#overlaps?` to `Range#overlap?` via rails#48565 , This commit is not feasible to backport because there is no `Range#overlap?` in Rails 7.0.z This commit addresses the CI faiilure at https://buildkite.com/rails/rails/builds/99745#018a9ea8-82f0-40a6-90c3-cdaa6dabebab/1092-1095 because without this commit, it shows `warning: method redefined; discarding old overlap?`. ```ruby $ ruby -v ruby 3.3.0dev (2023-09-16T05:57:19Z master e9b503f1bb) [x86_64-linux] $ RAILS_STRICT_WARNING=true bundle exec ruby -w -Itest test/core_ext/range_ext_test.rb /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/range/overlap.rb:7: warning: method redefined; discarding old overlap? Running 46 tests in a single process (parallelization threshold is 50) Run options: --seed 583 \# Running: .............................................. Finished in 0.011672s, 3940.9670 runs/s, 4883.3722 assertions/s. 46 runs, 57 assertions, 0 failures, 0 errors, 0 skips ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The method name
Range#overlaps?uses a 3rd person verb which is inconsistent with e.g.Range#include?andRange#cover?.Detail
This pull request renames
Range#overlaps?toRange#overlap?and adds an alias for backwards compatibility (similar toString#starts_with?).Checklist
[Fix #issue-number]