Remove connected? check from db_runtime payload #48708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for `Base.connected?` was added in rails@4ecdf24. At the time this change was made, we were calling `Base.connection.reset_runtime` so it made sense to check if the database was connected. Since rails@dd61a81 we have stored that information in a thread instead, negating the need to check `Base.connected?`. The problem with checking `Base.connected?` is that in a multi-db application this will return `false` for any model running a query not inheriting from `Base`, leaving the `db_runtime` payload `nil`. Since the information we need is stored in a thread rather than on the connection directly we can remove the `Base.connected?` check. Fixes rails#48687
|
Backported to 7-0-stable in eaf6dcf |
eileencodes
added a commit
that referenced
this pull request
Jul 11, 2023
…m-db_runtime Remove connected? check from db_runtime payload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for
Base.connected?was added in4ecdf24. At the time this change was made, we were calling
Base.connection.reset_runtimeso it made sense to check if the database was connected. Sincedd61a81 we have stored that information in a thread instead, negating the need to check
Base.connected?.The problem with checking
Base.connected?is that in a multi-db application this will returnfalsefor any model running a query not inheriting fromBase, leaving thedb_runtimepayloadnil. Since the information we need is stored in a thread rather than on the connection directly we can remove theBase.connected?check.Fixes #48687